Reduce Rails Dependencies to Railties#33
Open
BenMorganIO wants to merge 10 commits intobharget:mainfrom
Open
Conversation
Author
|
Hey there, just bumping this. |
Author
|
@bharget I'm sure you're very busy, but just giving this change another bump. |
simmerz
approved these changes
Sep 29, 2023
FawazFarid
approved these changes
Oct 12, 2023
|
@BenMorganIO I've forked this as mentioned in #37 and really liked this. If you open this against https://github.com/jclusso/heroicon-ruby, I'll get it merged in. This gem has way to many unnecessary dependencies. |
|
@BenMorganIO I've started work incorporating your changes into a PR. jclusso/heroicons#6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
This PR removes a large amount of rails dependencies to what is required by heroicon.
The whole dummy application was not required. It even hid a configuration setup for Heroicon that set up a test. That has been fixed.
The process was fairly simple. Check the Gemfile.lock into git so that I can track dependency removal and explicitly add each rails dependency. Then I went and individually removed each one until I figured out what was really going on. The dummy application, which wasn't even used, required the rails deps. So I commented out loading the dummy application and some more active storage configs in the test helper and reran the tests. A single failure was noticed and it just needed a configuration setup.